add instrunction and to use voicevox docker container.#556
Open
k-okada wants to merge 5 commits intojsk-ros-pkg:masterfrom
Open
add instrunction and to use voicevox docker container.#556k-okada wants to merge 5 commits intojsk-ros-pkg:masterfrom
k-okada wants to merge 5 commits intojsk-ros-pkg:masterfrom
Conversation
5984d00 to
0de83e9
Compare
- Add docker_only option for launching Docker container without ROS sound_play node - Add remote connection support with automatic local/remote detection - Improve README with detailed usage examples for different deployment scenarios - Fix host binding issues to prevent port conflicts when connecting to remote containers - Support GPU acceleration with proper documentation Features: - docker_only: Launch only Docker container (useful for server deployment) - Automatic local/remote detection based on host parameter - Enhanced run-voicevox-docker script with remote connection handling - Comprehensive documentation for all usage patterns
0de83e9 to
3efaf42
Compare
sawada10
approved these changes
Oct 20, 2025
Contributor
sawada10
left a comment
There was a problem hiding this comment.
I'm sorry for my late review.
Thank you for making PR.
I checked the procedures written in README, and they worked well.
I think the README is easy to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
voicevox_texttospeech.launchto work with docker container.